fix(check): respect oxlint exit code so denyWarnings fails vp check#1425
Draft
fix(check): respect oxlint exit code so denyWarnings fails vp check#1425
vp check#1425Conversation
`vp check` was unconditionally resetting the status to success whenever lint reported only warnings, masking the non-zero exit code produced by oxlint when `options.denyWarnings` (or `--deny-warnings`) is enabled. Drop the override and trust oxlint's exit code so warning-only runs fail the check when warnings have been opted in as failures. Closes #1424
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f6466c2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp checkwas unconditionally resetting the status to success wheneverlint reported only warnings, masking the non-zero exit code produced by
oxlint when
options.denyWarnings(or--deny-warnings) is enabled.Drop the override and trust oxlint's exit code so warning-only runs fail
the check when warnings have been opted in as failures.
Closes #1424
Note
Medium Risk
Changes
vp checkexit-code behavior for warning-only lint results, which can cause previously-passing pipelines to fail whendenyWarningsis enabled. Scope is small and localized to the check command plus a new regression snap-test.Overview
vp checkno longer forces a success exit status when oxlint reports only warnings; it now propagates oxlint’s actual exit code solint.options.denyWarnings(or--deny-warnings) correctly fails the check.Adds a new snap-test fixture
check-lint-warn-deny-warningsthat configuresdenyWarnings: truewith a warning-levelno-consolerule and asserts the expected warning output and summary.Reviewed by Cursor Bugbot for commit f6466c2. Configure here.