Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6a7fc41. Configure here.
| agent-service: | ||
| defaultAgent: | ||
| ## @param flyte-core.flyteagent.plugin_config.plugins.agent-service.defaultAgent.endpoint to set the grpc endpoint propeller uses to reach the flyteagent service. Format: `k8s://<service>.<namespace>:<port>`. | ||
| endpoint: "k8s://flyteagent.{{ .Release.Namespace }}:8000" |
There was a problem hiding this comment.
Helm template expression in values.yaml won't be rendered
High Severity
The endpoint value "k8s://flyteagent.{{ .Release.Namespace }}:8000" contains a Helm template expression, but values.yaml is a plain YAML data file — Helm does not render template expressions within it. The {{ .Release.Namespace }} will be passed as a literal string to the flyte-core subchart. The upstream flyte-core chart's default for this field uses a hardcoded namespace (k8s://flyteagent.flyte:8000), strongly suggesting its configmap template does not use tpl to process this value. As a result, propeller will attempt to connect to a malformed endpoint and fail to reach the flyteagent service, breaking all agent-routed tasks (e.g., Snowflake).
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 6a7fc41. Configure here.
1 participant
Note
Medium Risk
Introduces and enables a new in-cluster component (
flyteagent) and changes propeller plugin routing, which can affect task execution behavior and requires correct secret/image configuration.Overview
Enables Flyte’s
agent-servicetask plugin and deploys/configuresflyteagentas part of thetfy-workflow-propellerHelm chart (intended for Snowflake tasks).Adds new
values.yamlknobs for the propellerenabled_pluginsrouting (including mappingsnowflake->agent-service) and a newflyte-core.flyteagentblock to configure the agent endpoint/TLS mode, custom image, service account annotations, secret material (snowflake_private_key), and resource requests/limits; updates the chartREADME.mdto document these parameters.Reviewed by Cursor Bugbot for commit 6a7fc41. Bugbot is set up for automated code reviews on this repo. Configure here.