Skip to content

Add new job status metrics to values.yaml#2632

Open
shubhamrai1993 wants to merge 2 commits intomainfrom
shubhamrai1993-patch-1
Open

Add new job status metrics to values.yaml#2632
shubhamrai1993 wants to merge 2 commits intomainfrom
shubhamrai1993-patch-1

Conversation

@shubhamrai1993
Copy link
Copy Markdown
Contributor

@shubhamrai1993 shubhamrai1993 commented Apr 15, 2026

Note

Low Risk
Low risk config-only change that expands the kube-state-metrics allowlist; impact is limited to increased Prometheus series/cardinality for Job metrics.

Overview
Updates tfy-prometheus-config Helm values.yaml to keep additional Kubernetes Job status metrics from kube-state-metrics by extending the metricRelabelings allowlist (adds kube_job_status_failed, kube_job_status_succeeded, and kube_job_status_completion_time alongside existing Job metrics).

Reviewed by Cursor Bugbot for commit 7966914. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1d02b47. Configure here.

Comment thread charts/tfy-prometheus-config/values.yaml Outdated
@github-actions
Copy link
Copy Markdown

This PR will be automatically closed as it has been stale for 4 days. Please comment if you feel this is still relevant.

@github-actions github-actions bot added the stale label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants