fix: use storyNames in tree if available#697
Merged
dannyhw merged 2 commits intostorybookjs:nextfrom Mar 19, 2025
Merged
Conversation
Member
|
Hey @aniretaketea thanks so for much for your contribution, I haven't had time to test yet but seems good. Will test it out soon but I anticipate no issues with merging this in. thanks again. |
Contributor
Author
|
@dannyhw glad to be of help and give back! We actively use RN storybook in our project, thanks for maintaining and growing it |
dannyhw
added a commit
that referenced
this pull request
Mar 22, 2025
* fix: use storyNames in tree if available (#697) Co-authored-by: Daniel Williams <dannyhyunsoowilliams@gmail.com> * feat: allow storyName and name * v8.6.2 --------- Co-authored-by: Ekaterina Tarasova <aniretaketea@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: storyName property of stories is ignored in tree. There is no open issue, but there is a FIXME in code
What I did
Fixed index object generation in
prepareStoriesHow to test
An example story with storyName was added in
examples/expo-exampleunderUI/Sidebar/Tree