[6.x] Update currencies dictionary#14520
Conversation
|
I am sorry to say that the wikipedia list of circulating currencies is in no way a relevant source of information. Wikipedia cannot be listed as a relevant source for anything. ISO4217 is, absolutely. With the appropriate link |
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Thanks @ebeauchamps — you're right that Wikipedia isn't the source to cite. ISO 4217 (via SIX Group) is authoritative for codes and minor units, but worth noting ISO only defines one canonical English name per code and doesn't define symbols at all. The de-facto standard for display names and symbols is Unicode CLDR, which is what macOS, iOS, Android, PHP's intl, symfony/intl, etc. all use. The file pre-PR was already using CLDR-style friendly names (e.g. "Japanese Yen" rather than ISO's "Yen"), so the convention here is really ISO codes, CLDR names and symbols. I've pushed a commit that fixes the failing CurrenciesTest assertions and reconciles a few renames with CLDR's en data: BAM back to "Bosnia-Herzegovina…", BWP back to "Botswanan Pula", MMK to "Myanmar Kyat" (also fixes the original "Myanma" typo), and UZS to "Uzbekistani Som". Longer term I'll probably replace this with a thin wrapper over symfony/intl so we get CLDR data (and ~100 locales) for free, rather than hand-maintaining the list. (Sorry if my comment sounded like AI. It was.) |
|
Thanks @ebeauchamps and @jasonvarga. As mentioned this was my first time contributing so didn't know fully what source/format this original setup was using, was just trying to be helpful and fix an issue I came across. |
|
It's all good 👌 There was nothing super official there. Thanks for the PR! |
Brings the currency list in line with current ISO 4217 references.
Added 40 missing codes:
AOA,AWG,BBD,BMD,BSD,BTN,CUP,FJD,FKP,GIP,GMD,GYD,HTG,KGS,KPW,KYD,LAK,LRD,LSL,MNT,MRU,MVR,MWK,PGK,SBD,SCR,SHP,SLE,SRD,SSP,STN,SZL,TJS,TMT,VED,VUV,WST,XCD,XCG,XPF.Updated labels to match ISO 4217 / current official names:
BWP→Botswana PulaCZK→Czech KorunaILS→Israeli New ShekelMMK→Burmese KyatPEN→Peruvian Sol(reflects 2015 renaming)QAR→Qatari RiyalVES→Venezuelan Sovereign BolívarXAF/XOF→Central African CFA Franc/West African CFA FrancBAM,TTD→ lowercase "and"