Fix explicit_self false positives around string interpolation#6610
Open
jffmrk wants to merge 1 commit intorealm:mainfrom
Open
Fix explicit_self false positives around string interpolation#6610jffmrk wants to merge 1 commit intorealm:mainfrom
explicit_self false positives around string interpolation#6610jffmrk wants to merge 1 commit intorealm:mainfrom
Conversation
Generated by 🚫 Danger |
jffmrk
force-pushed
the
fix-explicit-self-string-interpolation
branch
from
01f0fc8 to
cedcca5
Compare
2 tasks
jffmrk
changed the title
explicit_self false positives around string interpolation
jffmrk
force-pushed
the
fix-explicit-self-string-interpolation
branch
from
f5e32b7 to
6dfa8fc
Compare
SourceKit can report instance-member refs for text inside string literals, at the open paren of \(...), or with offsets that do not match a simple '.' check. Combine SwiftSyntax static segment ranges with source-text verification for explicit self.<member> spans, and skip bogus offsets at string interpolation open parens. Add non-triggering, triggering, and correction examples for implicit member access inside string interpolation.
jffmrk
force-pushed
the
fix-explicit-self-string-interpolation
branch
from
6dfa8fc to
12dd5f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SourceKit can report misleading instance-member refs for
explicit_selfwhen code uses string literals and\(...)interpolation (e.g. literal text that matches a property name, or bogus offsets at the interpolation open paren).This PR filters those cases using SwiftSyntax static string segments, skips offsets at
\(, and verifies explicitself.` spans in source text.Fixes #6611
Testing
swift test --filter ExplicitSelfRuleGeneratedTestsMade with Cursor