You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
module and stream are user-supplied and end up unquoted in a shell string. This regresses the recent bfb2fafe ("security: quote untrusted values in command construction"). Suggested:
Scope: op is named module but only enables. Either rename to module_enable, or add present: bool = True and handle dnf module disable/reset symmetrically. As-is, dnf.module(..., present=False)-style expectations will be surprising.
Stream switching: dnf module enable won't switch streams when packages from the old stream are installed, it will error. Worth a docstring note, or auto-issuing a reset first.
Docs checkbox unchecked: docstrings are present and scripts/generate_operations_docs.py picks them up, so probably just an oversight.
Nice-to-have
Parse robustness (DnfEnabledModules.process): the \"[e]\" not in line filter is fine, but the startswith(\"Hint:\") guard is unreachable since the hint line contains no [e]. Remove or replace with a real edge case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1659
3.xat this time)scripts/dev-test.sh) (1552 passed, 15 deselected, 3 warnings in 7.93s)scripts/dev-lint.sh)