feat: added local persistence to ofrep-web provider#1508
Open
jsalaber wants to merge 8 commits intoopen-feature:mainfrom
Open
feat: added local persistence to ofrep-web provider#1508jsalaber wants to merge 8 commits intoopen-feature:mainfrom
jsalaber wants to merge 8 commits intoopen-feature:mainfrom
Conversation
jsalaber
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces persistent local caching for the OFREP Web provider using localStorage, including a new Storage utility that hashes targeting keys for privacy. The provider now supports cache-first initialization and context changes, with options to disable this behavior. Feedback points out a missing import for GeneralError that would cause a runtime error, and recommends a stale-while-revalidate approach to ensure cached data is eventually refreshed from the network. Other suggestions include hardening localStorage and JSON parsing logic against exceptions, and ensuring the correct context is used when clearing the cache after evaluation failures.
jsalaber
force-pushed
the
feat/local-persistence-ofrep-web
branch
2 times, most recently
from
9befa19 to
347de53
Compare
marcozabel
reviewed
Apr 8, 2026
jsalaber
force-pushed
the
feat/local-persistence-ofrep-web
branch
4 times, most recently
from
0443d45 to
4f9c6fe
Compare
kaushalkapasi
approved these changes
Apr 8, 2026
jsalaber
force-pushed
the
feat/local-persistence-ofrep-web
branch
from
4f9c6fe to
faf981c
Compare
marcozabel
approved these changes
Apr 9, 2026
Signed-off-by: Salaber <jason.salaber@dynatrace.com>
Signed-off-by: Salaber <jason.salaber@dynatrace.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Salaber <jason.salaber@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Salaber <jason.salaber@dynatrace.com>
jsalaber
force-pushed
the
feat/local-persistence-ofrep-web
branch
from
c58734a to
7c9f570
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Salaber <jason.salaber@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Salaber <jason.salaber@dynatrace.com>
…o prefix local storage keys Signed-off-by: Salaber <jason.salaber@dynatrace.com>
jsalaber
force-pushed
the
feat/local-persistence-ofrep-web
branch
from
ab29e37 to
9a7215a
Compare
beeme1mr
requested changes
Apr 20, 2026
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
The ADR referenced in the PR has been closed. There's a new one but it hasn't been merged yet. Let's old off merging this until that ADR has been accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
ofrep-webproviderCACHEDwhen using cached valuesdisableLocalCacheoption to disable local cacheRelated Issues
Implements this ADR: open-feature/protocol#64