feat: add unleash server provider#1230
Open
albertilagan wants to merge 4 commits intoopen-feature:mainfrom
Open
feat: add unleash server provider#1230albertilagan wants to merge 4 commits intoopen-feature:mainfrom
albertilagan wants to merge 4 commits intoopen-feature:mainfrom
Conversation
Signed-off-by: Albert Ilagan <me@albertilagan.dev>
albertilagan
force-pushed
the
albert/providers-unleash
branch
from
e05d173 to
2aa298c
Compare
Signed-off-by: Albert Ilagan <me@albertilagan.dev>
albertilagan
force-pushed
the
albert/providers-unleash
branch
from
f12ba2f to
ce784b1
Compare
beeme1mr
reviewed
Mar 17, 2025
Member
beeme1mr
left a comment
beeme1mr
left a comment
There was a problem hiding this comment.
Hey @albertilagan, thanks for the PR. I had some questions but mainly on the readme. The provider itself looks good.
Signed-off-by: Albert Ilagan <me@albertilagan.dev>
Signed-off-by: Albert Ilagan <me@albertilagan.dev>
toddbaert
reviewed
Mar 21, 2025
| private _config?: UnleashConfig; | ||
|
|
||
| // client is the Unleash client reference | ||
| private _client?: Unleash; |
Member
There was a problem hiding this comment.
I may be confused but I'm not sure where this is actually being assigned, initialize seems to return a void promise.
Perhaps that explains the test failures?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related issues
How to test