Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/server/mcp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,9 @@ export class McpServer {
}

// if the tool has an output schema, validate structured content
const outputObj = normalizeObjectSchema(tool.outputSchema) as AnyObjectSchema;
const parseResult = await safeParseAsync(outputObj, result.structuredContent);
const outputObj = normalizeObjectSchema(tool.outputSchema);
const schemaToParse = outputObj ?? (tool.outputSchema as AnySchema);
const parseResult = await safeParseAsync(schemaToParse, result.structuredContent);
if (!parseResult.success) {
const error = 'error' in parseResult ? parseResult.error : 'Unknown error';
const errorMessage = getParseErrorMessage(error);
Expand Down
68 changes: 68 additions & 0 deletions test/server/mcp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1295,6 +1295,74 @@ describe.each(zodTestMatrix)('$zodVersionLabel', (entry: ZodMatrixEntry) => {
expect(JSON.parse(textContent.text)).toEqual(result.structuredContent);
});

test('should support wrapped outputSchema variants', async () => {
const cases = [
{
label: 'optional',
outputSchema: z.object({ data: z.string() }).optional(),
structuredContent: { data: 'hello' }
},
{
label: 'nullable',
outputSchema: z.object({ data: z.string() }).nullable(),
structuredContent: { data: 'hello' }
},
{
label: 'nullish',
outputSchema: z.object({ data: z.string() }).nullish(),
structuredContent: { data: 'hello' }
},
{
label: 'union',
outputSchema: z.union([z.object({ data: z.string() }), z.object({ value: z.string() })]),
structuredContent: { data: 'hello' }
}
] as const;

for (const { label, outputSchema, structuredContent } of cases) {
const mcpServer = new McpServer({
name: `test server ${label}`,
version: '1.0'
});

const client = new Client({
name: `test client ${label}`,
version: '1.0'
});

mcpServer.registerTool(
`test-${label}`,
{
description: `Test tool with ${label} output schema`,
outputSchema
},
async () => ({
content: [],
structuredContent
})
);

const [clientTransport, serverTransport] = InMemoryTransport.createLinkedPair();

await Promise.all([client.connect(clientTransport), mcpServer.server.connect(serverTransport)]);

try {
await expect(
client.callTool({
name: `test-${label}`,
arguments: {}
})
).resolves.toMatchObject({
content: [],
structuredContent
});
} finally {
await client.close();
await mcpServer.server.close();
}
}
});

/***
* Test: Tool with Output Schema Must Provide Structured Content
*/
Expand Down
Loading