feat(jac-scale): validate email format on register/login#5598
Open
kashmithnisakya wants to merge 5 commits intojaseci-labs:mainfrom
Open
feat(jac-scale): validate email format on register/login#5598kashmithnisakya wants to merge 5 commits intojaseci-labs:mainfrom
kashmithnisakya wants to merge 5 commits intojaseci-labs:mainfrom
Conversation
fix: add ValidationError import for error handling in serve.jac deps: add email-validator dependency for email validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IdentityInputinto aLiteral-tagged discriminated union ofEmailIdentityInput(typed asEmailStr) andUsernameIdentityInput— pydantic now rejects malformed emails with a 422 before the request reaches the handler.format: emailfor email identities and emits a properdiscriminator+oneOfblock, so generated client SDKs validate client-side.email-validatortopyproject.toml(required by pydantic'sEmailStr).