Open
Conversation
Remove graceful degradation from "Bot responds to message" E2E test. The test now fails if the bot returns "Sorry, I encountered an error" instead of a valid response, ensuring a working LLM API key in CI.
The frontend has two error paths: "Sorry, I encountered an error" and "Sorry, something went wrong". Check for both to ensure the test fails when the LLM API call returns a 500.
Accessibility snapshot doesn't expose error text nodes. Use browser_evaluate to check document.body.innerText for "Sorry" which catches both error messages from the frontend.
The word 'Sorry' can appear in legitimate bot responses. Check for the exact frontend error messages instead: 'Sorry, I encountered an error' and 'Sorry, something went wrong'.
Playwright MCP browser_evaluate expects a 'function' parameter, not 'expression'. The wrong param was silently ignored, causing the bot response test to always fail.
Log browser_evaluate result to see what text the DOM actually contains when the test fails.
Clean up after confirming the test works correctly with the function parameter fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan