fix: require authenticating existing account to link oauth#27871
Open
fix: require authenticating existing account to link oauth#27871
Conversation
jrasm91
reviewed
Apr 16, 2026
bo0tzz
force-pushed
the
fix/oauth-linking
branch
3 times, most recently
from
e535be7 to
ef48f9c
Compare
bo0tzz
force-pushed
the
fix/oauth-linking
branch
from
532737b to
c2ef6eb
Compare
bo0tzz
force-pushed
the
fix/oauth-linking
branch
from
c2ef6eb to
d50ea00
Compare
jrasm91
approved these changes
Apr 18, 2026
Member
jrasm91
left a comment
jrasm91
left a comment
There was a problem hiding this comment.
Looks great. I'll have to do some testing on Monday.
jrasm91
reviewed
Apr 18, 2026
Comment on lines
+25
to
+26
| const handleSubmit = async (event: Event) => { | ||
| event.preventDefault(); |
Member
There was a problem hiding this comment.
Suggested change
| const handleSubmit = async (event: Event) => { | |
| event.preventDefault(); | |
| const handleSubmit = async () => { |
Member
Author
There was a problem hiding this comment.
Why shouldn't we preventDefault here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, first OAuth login will automatically link to any existing Immich account with a matching email address. On some IDP configurations, this may allow for account takeover. This PR changes the process to require entering the password of an existing Immich account before being able to link it to an OAuth identity.
How Has This Been Tested?
Configured OAuth, then ran through the various flows.
2026-04-16.20-40-50.mp4