[Mono.Android] Enumify API-37.0, API-37.0 is "Stable"#11151
Draft
jonpryor wants to merge 1 commit intodotnet:mainfrom
Draft
[Mono.Android] Enumify API-37.0, API-37.0 is "Stable"#11151jonpryor wants to merge 1 commit intodotnet:mainfrom
jonpryor wants to merge 1 commit intodotnet:mainfrom
Conversation
Member
|
/review |
|
✅ Android PR Reviewer completed successfully! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 AI Review Summary
Verdict:
Found 4 issues in the API 37 enumification map.csv entries:
- ❌ Wrong enum type:
AlcoholConsumptionRecord.RECORD_TEMPORAL_TYPE_*constants are mapped toAlcoholConsumptionBeverageTypeinstead of a separate temporal-type enum (map.csv:3391-3393) - ❌ Typo:
KillExcessivCpuUsage→KillExcessiveCpuUsage(missing 'e') — this becomes a public API name (map.csv:9754) ⚠️ Namespace casing:Android.Content.Pm.Webappshould beAndroid.Content.PM.Webappto match existingandroid.content.pmconvention (map.csv:2208-2223)⚠️ Redundant prefixes: Several new member names include the enum type name as a prefix, inconsistent with existing members in the same enum types (6 instances acrossNetCapability,DocumentContractFlags,DocumentRootFlags,ProfilingTriggerType)
👍 The Documentation path updates (xamarin-android → dotnet/android) and metadata ns-replace additions look correct. The LIGHT_CAPABILITY_* flags fix and CarrierConfigManager ? → I decisions are good cleanup.
Review generated by android-reviewer from review guidelines.
Note
🔒 Integrity filter blocked 2 items
The following items were blocked because they don't meet the GitHub integrity level.
- #11151
pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved". - #11151
pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
To allow these resources, lower min-integrity in your GitHub frontmatter:
tools:
github:
min-integrity: approved # merged | approved | unapproved | noneGenerated by Android PR Reviewer for issue #11151 · ● 26.6M
Context: http://github.com/jpobst/BindingStudio Context: dotnet#10005 Use jpobst/BindingStudio to begin enumifying API-36.1. Note: current dotnet/java-interop emits an "extra" `,` on `map.csv` output, which would make for a "noisy" diff (every line changed!). The diff size is reduced by removing trailing commas: sed 's/,$//' < src/Mono.Android/new-map.csv > src/Mono.Android/map.csv This keeps the diff to a reasonable size. Sanity check: during enumification, this should have no matches: git grep '\.[A-Z][a-z]\.' src/Mono.Android/map.csv Two-letter namespace parts should be all upper-case. TODO (lol): update `map.csv` to current BindingStudio output after this is merged. WIP. Current state: finished **Creating enums**. Need to perform: * **Extract methods that possibly need enums** * **Mapping methods** Commit [Extract constants from API][0] output. [0]: https://github.com/dotnet/android/blob/e67a3fd36ca5e24b0007a170ea77037e4437f9d3/Documentation/workflow/HowToAddNewApiLevel.md#extract-constants-from-api
jonpryor
force-pushed
the
dev/jonpryor/jonp-enumify-api-37
branch
from
8de222f to
54877b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: http://github.com/jpobst/BindingStudio
Context: #10005
Use jpobst/BindingStudio to begin enumifying API-36.1.
Note: current dotnet/java-interop emits an "extra"
,onmap.csvoutput, which would make for a "noisy" diff (every line changed!). The diff size is reduced by removing trailing commas:This keeps the diff to a reasonable size.
TODO (lol): update
map.csvto current BindingStudio output after this is merged.WIP.
Current state: finished Creating enums.
Need to perform:
Commit Extract constants from API output.
Pull Request
title and
description
should follow the
commit-messages.mdworkflow documentation, and in particular should include: