fix(animated-fab): correct Android shadow/content stacking#4903
Open
BogiKay wants to merge 1 commit intocallstack:mainfrom
Open
fix(animated-fab): correct Android shadow/content stacking#4903BogiKay wants to merge 1 commit intocallstack:mainfrom
BogiKay wants to merge 1 commit intocallstack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a stacking issue affecting
AnimatedFABon Android 9. The component renders shadow and content as sibling layers and on Android 9 an elevated view also affects z-order for overlapping siblings. In this case, the elevated shadow layer can render above the FAB content. This change explicitly sets the sibling z-index on Android so the content stays above the shadow.Related issue
#4848
Test plan
before-android-9.webm
after-android-9.webm
before-ios.mov
after-ios.mov