[ty] Widen nested literals during inference for huge collections#24716
Draft
charliermarsh wants to merge 2 commits intomainfrom
Draft
[ty] Widen nested literals during inference for huge collections#24716charliermarsh wants to merge 2 commits intomainfrom
charliermarsh wants to merge 2 commits intomainfrom
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.94%. The percentage of expected errors that received a diagnostic held steady at 83.36%. The number of fully passing files held steady at 79/133. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
sphinx
|
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-argument-type |
0 | 0 | 2 |
no-matching-overload |
0 | 0 | 1 |
| Total | 0 | 0 | 3 |
Raw diff:
freqtrade (https://github.com/freqtrade/freqtrade)
- freqtrade/optimize/optimize_reports/optimize_reports.py:670:48 error[invalid-argument-type] Argument to function `calculate_trade_volume` is incorrect: Expected `list[dict[str, Any]]`, found `list[dict[Hashable, Any]]`
+ freqtrade/optimize/optimize_reports/optimize_reports.py:670:48 error[invalid-argument-type] Argument is incorrect: Expected `list[dict[str, Any]]`, found `list[dict[Hashable, Any]]`
- freqtrade/optimize/optimize_reports/optimize_reports.py:687:47 error[invalid-argument-type] Argument to function `generate_wallet_stats` is incorrect: Expected `DataFrame`, found `DataFrame | None`
+ freqtrade/optimize/optimize_reports/optimize_reports.py:687:47 error[invalid-argument-type] Argument is incorrect: Expected `DataFrame`, found `DataFrame | None`
zulip (https://github.com/zulip/zulip)
- zproject/urls.py:316:5 error[no-matching-overload] No overload of function `path` matches arguments
+ zproject/urls.py:316:5 error[no-matching-overload] No overload matches arguments
Merging this PR will degrade performance by 10.33%
Performance Changes
Comparing 
Footnotes
|
charliermarsh
force-pushed
the
charlie/promote-perf
branch
2 times, most recently
from
afd662c to
ee4b6e2
Compare
charliermarsh
force-pushed
the
charlie/promote-perf
branch
from
ee4b6e2 to
80d61d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For a collection like:
We created a huge union of the key literals, which timed out in inference after 12 seconds (according to Codex), but now completes in 0.040s.
We now fallback to inferring
strrather than aLiteralfor each key here and elsewhere.Discovered as part of: astral-sh/ty#1393.