Skip to content

Upgrade/Install: List available translation updates on the Updates screen#11610

Draft
s-a-s-k-i-a wants to merge 1 commit intoWordPress:trunkfrom
s-a-s-k-i-a:42281-list-translation-updates
Draft

Upgrade/Install: List available translation updates on the Updates screen#11610
s-a-s-k-i-a wants to merge 1 commit intoWordPress:trunkfrom
s-a-s-k-i-a:42281-list-translation-updates

Conversation

@s-a-s-k-i-a
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/42281

Summary

list_translation_updates() currently renders only a generic "New translations are available." message and the Update Translations button. Unlike the WordPress core, plugin, and theme update sections, it does not resolve or display the specific translation updates that are pending, so there is no pre-upgrade visibility into which component/language/version combinations will be updated.

This PR adds display helpers for translation updates and uses them on update-core.php to list the pending translation updates before the upgrade runs.

Changes

  • add translation update display helpers in wp-admin/includes/update.php
  • resolve translation update names for core, themes, and plugins
  • map plugin translation slugs back to installed plugin files so WordPress.org-style slugs still display the correct plugin name
  • display a translations count and a per-update list on wp-admin/update-core.php
  • add PHPUnit coverage for translation update display data, including plugin slug fallback behavior

Test plan

  • php -l src/wp-admin/includes/update.php
  • php -l src/wp-admin/update-core.php
  • php -l tests/phpunit/tests/admin/includesUpdate.php
  • vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-admin/includes/update.php src/wp-admin/update-core.php tests/phpunit/tests/admin/includesUpdate.php
  • Authenticated HTTP smoke test against https://wpcore.wp-studio.dev/wp-admin/update-core.php with a temporary MU-plugin fixture injecting controlled core, plugin, and theme translation updates; verified the rendered translations section shows a count of 3 and entries for WordPress, Hello Dolly, and Twenty Twenty-Four
  • PHPUnit execution for Tests_Admin_IncludesUpdate could not be run in this environment because the local WordPress test configuration / Docker test environment was unavailable

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5-based Codex
Used for: implementation, test scaffolding, server-side smoke-test orchestration, and PR drafting; outputs were reviewed and validated with syntax checks, PHPCS, and an authenticated admin-page smoke test.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

Hi @s-a-s-k-i-a! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant