Tests: Use assertSame() in get_adjacent_post() tests.#11602
Tests: Use assertSame() in get_adjacent_post() tests.#11602sagarsdeshmukh wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
a9b9edc to
5944475
Compare
|
Thanks for the PR! Merged in r62247. |
Replaces loose
assertEquals()withassertSame()for scalar integer ID comparisons in theget_adjacent_post()andget_boundary_post()tests.Object comparisons against full WP_Post instances are intentionally kept as
assertEquals(), sinceassertSame()uses strict===comparison which requires the same PHP object instance, that would fail for objects fetched via separate database calls.See https://core.trac.wordpress.org/ticket/64324