Skip to content

Tests: Use assertSame() in get_adjacent_post() tests.#11602

Closed
sagarsdeshmukh wants to merge 1 commit intoWordPress:trunkfrom
sagarsdeshmukh:assertsame-getadjacentpost
Closed

Tests: Use assertSame() in get_adjacent_post() tests.#11602
sagarsdeshmukh wants to merge 1 commit intoWordPress:trunkfrom
sagarsdeshmukh:assertsame-getadjacentpost

Conversation

@sagarsdeshmukh
Copy link
Copy Markdown

@sagarsdeshmukh sagarsdeshmukh commented Apr 20, 2026

Replaces loose assertEquals() with assertSame() for scalar integer ID comparisons in the get_adjacent_post() and get_boundary_post() tests.

Object comparisons against full WP_Post instances are intentionally kept as assertEquals(), since assertSame() uses strict === comparison which requires the same PHP object instance, that would fail for objects fetched via separate database calls.

See https://core.trac.wordpress.org/ticket/64324

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sagardeshmukh.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sagarsdeshmukh sagarsdeshmukh force-pushed the assertsame-getadjacentpost branch from a9b9edc to 5944475 Compare April 20, 2026 10:46
@SergeyBiryukov
Copy link
Copy Markdown
Member

Thanks for the PR! Merged in r62247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants