This repository was archived by the owner on Apr 20, 2018. It is now read-only.
Open
Conversation
|
@ahstro have you had any luck converting the rest of it? I'd be happy to help out once I get there (I just started the first file tonight). Maybe once it's done, @mattpodwysocki would be more inclined to merge this in. |
Author
|
I haven't had a look at it and don't really have the time right now, so if you're willing to look at it, that'd be great :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to work through the koans, but since I'm using RxJS 5 and they were in RxJS 4, I decided to convert them as well. I'm not sure if this is wanted, but thought I might as well open a PR, if not for the merge than at least for others to see that there's a RxJS 5 version available.
I took the liberty to enable ES6 and stage-0 JavaScript, just for my own enjoyment, so if that's not desirable.. well, okay :)
Also, there are about three koans from the original that have not been converted (they're commented out) because the operators used have not been implemented yet and it's almost 2 at night, so I'm not going to look into fixing those right now.
Thanks for this project, it was fun working through :)