fix(core): Address latest review feedback

- iOS: Add NSArray type check on path data in convertMultiClick to
  prevent runtime crash from unrecognized selector on non-array values
  (HIGH, Sentry bot).

- Clear tap buffer when detection is disabled via updateOptions to
  prevent stale taps from causing false positives on re-enable
  (LOW, Sentry bot).

- Move changelog entry from released 8.8.0 section to Unreleased
  (danger bot).

- Add time window integration test to touchevents that varies
  timestamps between taps, verifying rageTapTimeWindow actually
  excludes old taps (sentry-warden).

Author: alwx

CHANGELOG.md

@@ -13,6 +13,7 @@
 - Expose screenshot masking options (`screenshot.maskAllText`, `screenshot.maskAllImages`, `screenshot.maskedViewClasses`, `screenshot.unmaskedViewClasses`) for error screenshots ([#6007](https://github.com/getsentry/sentry-react-native/pull/6007))
 - Warn Expo users at Metro startup when prebuilt native projects are missing Sentry configuration ([#5984](https://github.com/getsentry/sentry-react-native/pull/5984))
 - Add `Sentry.GlobalErrorBoundary` component (and `withGlobalErrorBoundary` HOC) that renders a fallback UI for fatal non-rendering JS errors routed through `ErrorUtils` in addition to the render-phase errors caught by `Sentry.ErrorBoundary`. Opt-in flags `includeNonFatalGlobalErrors` and `includeUnhandledRejections` extend the fallback to non-fatal errors and unhandled promise rejections respectively. ([#6023](https://github.com/getsentry/sentry-react-native/pull/6023))
+- Add rage tap detection — rapid consecutive taps on the same element emit `ui.multiClick` breadcrumbs and appear on the replay timeline with the rage click icon ([#5992](https://github.com/getsentry/sentry-react-native/pull/5992))
 
 ### Fixes
 
@@ -39,7 +40,6 @@
 - Add `strictTraceContinuation` and `orgId` options for trace continuation validation ([#5829](https://github.com/getsentry/sentry-react-native/pull/5829))
 - Add `deeplinkIntegration` for automatic deep link breadcrumbs ([#5983](https://github.com/getsentry/sentry-react-native/pull/5983))
 - Name navigation spans using dispatched action payload when `useDispatchedActionData` is enabled ([#5982](https://github.com/getsentry/sentry-react-native/pull/5982))
-- Add rage tap detection — rapid consecutive taps on the same element emit `ui.multiClick` breadcrumbs and appear on the replay timeline with the rage click icon ([#5992](https://github.com/getsentry/sentry-react-native/pull/5992))
 
 ### Fixes
 

packages/core/ios/RNSentryReplayBreadcrumbConverter.m

@@ -85,8 +85,12 @@ - (instancetype _Nonnull)init
         return nil;
     }
 
-    NSMutableArray *path = [breadcrumb.data valueForKey:@"path"];
-    NSString *message = [RNSentryReplayBreadcrumbConverter getTouchPathMessageFrom:path];
+    id maybePath = [breadcrumb.data valueForKey:@"path"];
+    if (![maybePath isKindOfClass:[NSArray class]]) {
+        return nil;
+    }
+
+    NSString *message = [RNSentryReplayBreadcrumbConverter getTouchPathMessageFrom:maybePath];
 
     return [SentrySessionReplayHybridSDK createBreadcrumbwithTimestamp:breadcrumb.timestamp
                                                               category:@"ui.multiClick"

packages/core/src/js/ragetap.ts

@@ -50,6 +50,9 @@ export class RageTapDetector {
   public updateOptions(options: Partial<RageTapDetectorOptions>): void {
     if (options.enabled !== undefined) {
       this._enabled = options.enabled;
+      if (!this._enabled) {
+        this._recentTaps = [];
+      }
     }
     if (options.threshold !== undefined) {
       this._threshold = options.threshold;

packages/core/test/touchevents.test.tsx

@@ -419,6 +419,38 @@ describe('TouchEventBoundary._onTouchStart', () => {
         }),
       );
     });
+
+    it('does not trigger when taps are outside the time window', () => {
+      const { defaultProps } = TouchEventBoundary;
+      const boundary = new TouchEventBoundary(defaultProps);
+      const nowMock = jest.spyOn(Date, 'now');
+
+      const event = {
+        _targetInst: {
+          elementType: { displayName: 'Button' },
+          memoizedProps: { 'sentry-label': 'submit' },
+        },
+      };
+
+      nowMock.mockReturnValue(1000);
+      // @ts-expect-error Calling private member
+      boundary._onTouchStart(event);
+
+      nowMock.mockReturnValue(1500);
+      // @ts-expect-error Calling private member
+      boundary._onTouchStart(event);
+
+      // Third tap beyond 1000ms default window
+      nowMock.mockReturnValue(2500);
+      // @ts-expect-error Calling private member
+      boundary._onTouchStart(event);
+
+      // Only touch breadcrumbs, no multiClick
+      expect(addBreadcrumb).toHaveBeenCalledTimes(3);
+      for (const call of addBreadcrumb.mock.calls) {
+        expect(call[0].category).toBe('touch');
+      }
+    });
   });
 
   describe('sentry-span-attributes', () => {