extract iscoroutinefunction into common

Author: cooperoptigrid

sentry_sdk/integrations/_asgi_common.py

@@ -1,3 +1,5 @@
+import asyncio
+import inspect
 import urllib
 
 from sentry_sdk.scope import should_send_default_pii
@@ -9,11 +11,30 @@
     from typing import Any
     from typing import Dict
     from typing import Optional
+    from typing import TypeVar
     from typing import Union
     from typing_extensions import Literal
 
     from sentry_sdk.utils import AnnotatedValue
 
+    _F = TypeVar("_F")
+
+
+# Python 3.12 deprecates asyncio.iscoroutinefunction() as an alias for
+# inspect.iscoroutinefunction(), whilst also removing the _is_coroutine marker.
+# The latter is replaced with inspect.markcoroutinefunction().
+# Until 3.12 is the minimum supported Python version, provide a shim.
+# This was copied from https://github.com/django/asgiref/blob/main/asgiref/sync.py
+if hasattr(inspect, "markcoroutinefunction"):
+    _iscoroutinefunction = inspect.iscoroutinefunction
+    _markcoroutinefunction = inspect.markcoroutinefunction
+else:
+    _iscoroutinefunction = asyncio.iscoroutinefunction  # type: ignore[assignment]
+
+    def _markcoroutinefunction(func: "_F") -> "_F":
+        func._is_coroutine = asyncio.coroutines._is_coroutine  # type: ignore[attr-defined]
+        return func
+
 
 def _get_headers(asgi_scope: "Any") -> "Dict[str, str]":
     """

sentry_sdk/integrations/asgi.py

@@ -5,7 +5,6 @@
 """
 
 import sys
-import asyncio
 import inspect
 from copy import deepcopy
 from functools import partial
@@ -18,6 +17,7 @@
     _get_request_attributes,
     _get_request_data,
     _get_url,
+    _iscoroutinefunction,
 )
 from sentry_sdk.integrations._wsgi_common import (
     DEFAULT_HTTP_METHODS_TO_CAPTURE,
@@ -87,10 +87,10 @@ def _looks_like_asgi3(app: "Any") -> bool:
     if inspect.isclass(app):
         return hasattr(app, "__await__")
     elif inspect.isfunction(app):
-        return asyncio.iscoroutinefunction(app)
+        return _iscoroutinefunction(app)
     else:
         call = getattr(app, "__call__", None)  # noqa
-        return asyncio.iscoroutinefunction(call)
+        return _iscoroutinefunction(call)
 
 
 class SentryAsgiMiddleware:

sentry_sdk/integrations/django/asgi.py

@@ -6,16 +6,18 @@
 `django.core.handlers.asgi`.
 """
 
-import asyncio
 import functools
-import inspect
 
 from django.core.handlers.wsgi import WSGIRequest
 
 import sentry_sdk
 from sentry_sdk.consts import OP
 
 from sentry_sdk.integrations.asgi import SentryAsgiMiddleware
+from sentry_sdk.integrations._asgi_common import (
+    _iscoroutinefunction,
+    _markcoroutinefunction,
+)
 from sentry_sdk.scope import should_send_default_pii
 from sentry_sdk.utils import (
     capture_internal_exceptions,
@@ -25,31 +27,13 @@
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
-    from typing import Any, Callable, Union, TypeVar
+    from typing import Any, Callable, Union
 
     from django.core.handlers.asgi import ASGIRequest
     from django.http.response import HttpResponse
 
     from sentry_sdk._types import Event, EventProcessor
 
-    _F = TypeVar("_F", bound=Callable[..., Any])
-
-
-# Python 3.12 deprecates asyncio.iscoroutinefunction() as an alias for
-# inspect.iscoroutinefunction(), whilst also removing the _is_coroutine marker.
-# The latter is replaced with the inspect.markcoroutinefunction decorator.
-# Until 3.12 is the minimum supported Python version, provide a shim.
-# This was copied from https://github.com/django/asgiref/blob/main/asgiref/sync.py
-if hasattr(inspect, "markcoroutinefunction"):
-    iscoroutinefunction = inspect.iscoroutinefunction
-    markcoroutinefunction = inspect.markcoroutinefunction
-else:
-    iscoroutinefunction = asyncio.iscoroutinefunction  # type: ignore[assignment]
-
-    def markcoroutinefunction(func: "_F") -> "_F":
-        func._is_coroutine = asyncio.coroutines._is_coroutine  # type: ignore
-        return func
-
 
 def _make_asgi_request_event_processor(request: "ASGIRequest") -> "EventProcessor":
     def asgi_request_event_processor(event: "Event", hint: "dict[str, Any]") -> "Event":
@@ -215,15 +199,15 @@ def _async_check(self) -> None:
             a thread is not consumed during a whole request.
             Taken from django.utils.deprecation::MiddlewareMixin._async_check
             """
-            if iscoroutinefunction(self.get_response):
-                markcoroutinefunction(self)
+            if _iscoroutinefunction(self.get_response):
+                _markcoroutinefunction(self)
 
         def async_route_check(self) -> bool:
             """
             Function that checks if we are in async mode,
             and if we are forwards the handling of requests to __acall__
             """
-            return iscoroutinefunction(self.get_response)
+            return _iscoroutinefunction(self.get_response)
 
         async def __acall__(self, *args: "Any", **kwargs: "Any") -> "Any":
             f = self._acall_method

sentry_sdk/integrations/django/views.py

@@ -2,19 +2,14 @@
 
 import sentry_sdk
 from sentry_sdk.consts import OP
+from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
 
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from typing import Any
 
 
-try:
-    from asyncio import iscoroutinefunction
-except ImportError:
-    iscoroutinefunction = None  # type: ignore
-
-
 try:
     from sentry_sdk.integrations.django.asgi import wrap_async_view
 except (ImportError, SyntaxError):
@@ -48,10 +43,8 @@ def sentry_patched_make_view_atomic(
 
         integration = sentry_sdk.get_client().get_integration(DjangoIntegration)
         if integration is not None:
-            is_async_view = (
-                iscoroutinefunction is not None
-                and wrap_async_view is not None
-                and iscoroutinefunction(callback)
+            is_async_view = wrap_async_view is not None and _iscoroutinefunction(
+                callback
             )
             if is_async_view:
                 sentry_wrapped_callback = wrap_async_view(callback)

sentry_sdk/integrations/fastapi.py

@@ -1,9 +1,9 @@
-import inspect
 from copy import deepcopy
 from functools import wraps
 
 import sentry_sdk
 from sentry_sdk.integrations import DidNotEnable
+from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
 from sentry_sdk.scope import should_send_default_pii
 from sentry_sdk.tracing import SOURCE_FOR_STYLE, TransactionSource
 from sentry_sdk.utils import transaction_from_function
@@ -73,7 +73,7 @@ def _sentry_get_request_handler(*args: "Any", **kwargs: "Any") -> "Any":
         if (
             dependant
             and dependant.call is not None
-            and not inspect.iscoroutinefunction(dependant.call)
+            and not _iscoroutinefunction(dependant.call)
         ):
             old_call = dependant.call
 

sentry_sdk/integrations/quart.py

@@ -1,9 +1,9 @@
-import asyncio
 import inspect
 from functools import wraps
 
 import sentry_sdk
 from sentry_sdk.integrations import DidNotEnable, Integration
+from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
 from sentry_sdk.integrations._wsgi_common import _filter_headers
 from sentry_sdk.integrations.asgi import SentryAsgiMiddleware
 from sentry_sdk.scope import should_send_default_pii
@@ -106,9 +106,7 @@ def _sentry_route(*args: "Any", **kwargs: "Any") -> "Any":
         old_decorator = old_route(*args, **kwargs)
 
         def decorator(old_func: "Any") -> "Any":
-            if inspect.isfunction(old_func) and not asyncio.iscoroutinefunction(
-                old_func
-            ):
+            if inspect.isfunction(old_func) and not _iscoroutinefunction(old_func):
 
                 @wraps(old_func)
                 @ensure_integration_enabled(QuartIntegration, old_func)

sentry_sdk/integrations/starlette.py

@@ -1,4 +1,3 @@
-import inspect
 import functools
 import warnings
 from collections.abc import Set
@@ -12,6 +11,7 @@
     Integration,
     _DEFAULT_FAILED_REQUEST_STATUS_CODES,
 )
+from sentry_sdk.integrations._asgi_common import _iscoroutinefunction
 from sentry_sdk.integrations._wsgi_common import (
     DEFAULT_HTTP_METHODS_TO_CAPTURE,
     HttpCodeRangeContainer,
@@ -424,8 +424,8 @@ def _is_async_callable(obj: "Any") -> bool:
     while isinstance(obj, functools.partial):
         obj = obj.func
 
-    return inspect.iscoroutinefunction(obj) or (
-        callable(obj) and inspect.iscoroutinefunction(obj.__call__)
+    return _iscoroutinefunction(obj) or (
+        callable(obj) and _iscoroutinefunction(obj.__call__)
     )