Encode parmeters for metrics-server

alexellis · alexellis · commit 0ff2d67a665c · 2019-10-28T20:22:26.000Z
As reported by @jeka, this change escapes the commas in the "args" parameter to the helm chart. Tested before/after the patch and confirmed that all options are now being passed to the deployment. Closes: #73 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
diff --git a/pkg/cmd/metricsserver_app.go b/pkg/cmd/metricsserver_app.go
@@ -66,7 +66,7 @@ func makeInstallMetricsServer() *cobra.Command {
 		}
 
 		overrides := map[string]string{}
-		overrides["args"] = `{--kubelet-insecure-tls,--kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname}`
+		overrides["args"] = `{--kubelet-insecure-tls,--kubelet-preferred-address-types=InternalIP\,ExternalIP\,Hostname}`
 		fmt.Println("Chart path: ", chartPath)
 		outputPath := path.Join(chartPath, "metrics-server/rendered")
 

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func makeInstallMetricsServer() *cobra.Command {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`overrides := map[string]string{}`
`69`		- overrides["args"] = `{--kubelet-insecure-tls,--kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname}`
	`69`	+ overrides["args"] = `{--kubelet-insecure-tls,--kubelet-preferred-address-types=InternalIP\,ExternalIP\,Hostname}`
`70`	`70`	`fmt.Println("Chart path: ", chartPath)`
`71`	`71`	`outputPath := path.Join(chartPath, "metrics-server/rendered")`
`72`	`72`