File tree Expand file tree Collapse file tree 3 files changed +22
-1
lines changed
Expand file tree Collapse file tree 3 files changed +22
-1
lines changed Original file line number Diff line number Diff line change 11# Changelog
22## Unreleased
33
4+ ## 0.3.1 - 2021-07-31
5+
6+ ### Fixed
7+
8+ - Cast Memory and Timeout to integers. Fixes [ #28 ] ( https://github.com/hammerstonedev/sidecar/issues/28 )
9+
410## 0.3.0 - 2021-07-20
511
612### Added
Original file line number Diff line number Diff line change @@ -21,4 +21,19 @@ public function app_name_with_a_space_gets_dashed()
2121 (new EmptyTestFunction )->nameWithPrefix ()
2222 );
2323 }
24+
25+ /** @test */
26+ public function memory_and_timeout_get_cast_to_ints ()
27+ {
28+ config ([
29+ 'sidecar.timeout ' => '5 ' ,
30+ 'sidecar.memory ' => '500 '
31+ ]);
32+
33+ $ array = (new EmptyTestFunction )->toDeploymentArray ();
34+
35+ $ this ->assertSame (5 , $ array ['Timeout ' ]);
36+ $ this ->assertSame (500 , $ array ['MemorySize ' ]);
37+ }
38+
2439}
Original file line number Diff line number Diff line change @@ -16,6 +16,6 @@ public function handler()
1616
1717 public function package ()
1818 {
19- //
19+ return optional ();
2020 }
2121}
You can’t perform that action at this time.
0 commit comments